-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/ins 1660 tooltip issues #5239
Conversation
84e8426
to
b954a39
Compare
It took some time to read upon code of react-stately as it didn't seem to have good documentation. It's a cool headless UI, I have to admit. One interesting thing I discovered though is captured here: I wonder if we should discuss what benefits this library would entail. I am looking at it positively, but how will we incorporate theme context with this for instance? Will it ever have a conflict if we put all the design tokens into the theme context/provider and read from it? |
b954a39
to
5863f66
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran smoke tests and it works as expected. I wonder if we can shorten the delay time to display but that is just my personal opinion. Thanks for explanation on the call.
5863f66
to
d8c172a
Compare
Good one! Moving to a function component I didn't keep the default value of 400ms. |
ccc7261
to
9f36d88
Compare
Fixes tooltip positioning and open/close state issues.
Highlights:
React-Aria pros/cons
changelog(Fixes): Fixed an issue with tooltip