Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix duplicate error response after upgrade #5241

Merged
merged 2 commits into from
Oct 4, 2022

Conversation

jackkav
Copy link
Contributor

@jackkav jackkav commented Oct 3, 2022

errors like ENOTFOUND are triggered before the upgrade event
and those like Server sent a subprotocol but none was requested occur after the upgrade event. This means we our error event may or may not need to create an error response object.

changelog(Fixes): Fixed duplicate error response after upgrade

Copy link
Contributor

@marckong marckong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I wonder if it would be beneficial to add e2e test to catch this.

@jackkav jackkav marked this pull request as ready for review October 4, 2022 21:04
@jackkav jackkav force-pushed the fix/remove-subprotocol-error-response branch from e809dda to 194ea90 Compare October 4, 2022 21:59
@jackkav jackkav enabled auto-merge (squash) October 4, 2022 22:02
@jackkav jackkav merged commit d5ec273 into Kong:develop Oct 4, 2022
@jackkav jackkav deleted the fix/remove-subprotocol-error-response branch October 4, 2022 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants