Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

o2k: removed partial support for oauth2 #5260

Merged
merged 2 commits into from
Oct 12, 2022
Merged

o2k: removed partial support for oauth2 #5260

merged 2 commits into from
Oct 12, 2022

Conversation

jackkav
Copy link
Contributor

@jackkav jackkav commented Oct 11, 2022 •
edited by filfreire
Loading

oidc workaround was causing conflicts when inferring security schema -> kong plugin config

Closes INS-2027

changelog(OpenAPI-2-Kong): Removed an implicit workaround that was causing plugin conflicts when inferring security schema

@jackkav jackkav requested a review from Tieske October 11, 2022 14:30
@jackkav jackkav merged commit 49a792b into Kong:develop Oct 12, 2022
@jackkav jackkav deleted the feature/ins-2027-inso-cli-converting-openid-security branch October 12, 2022 15:39
Tieske
Tieske reviewed Oct 12, 2022
View reviewed changes
Copy link
Member

@Tieske Tieske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it'll solve the problem, but ideally we'd remove all security generation. Since they cannot be generated reliably.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tieske Tieske Tieske left review comments

@marckong marckong marckong approved these changes

@filfreire filfreire filfreire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jackkav @Tieske @filfreire @marckong