Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INS-2119] Inso CLI logging parity #5408

Merged
merged 2 commits into from
Nov 15, 2022

Conversation

filfreire
Copy link
Member

@filfreire filfreire commented Nov 14, 2022

changelog(Inso CLI): Improved the log output of inso lint spec command to print warning logs

Closes INS-2119

Workaround changes so the log output matches the default of spectral cli:

  • Keep failing on on errors, but print out any results found
  • Warn if errors or warnings are present in results
  • Add a small info note on the ruleset being used (since we get that question a lot of which ruleset is used)

After change, on Inso CLI
image

On spectral:
image

@filfreire filfreire changed the title feature/ins 2119 inso cli linting output logs [INS-2119] Inso CLI logging parity Nov 14, 2022
@filfreire filfreire force-pushed the feature/ins-2119-inso-cli-linting-output-logs branch from fe7a584 to 9255fc1 Compare November 14, 2022 12:07
@filfreire filfreire requested a review from a team November 14, 2022 12:11
@filfreire filfreire marked this pull request as ready for review November 14, 2022 12:11
@filfreire filfreire force-pushed the feature/ins-2119-inso-cli-linting-output-logs branch 3 times, most recently from 3779a17 to 5b734c0 Compare November 15, 2022 11:16
@filfreire filfreire self-assigned this Nov 15, 2022
@filfreire filfreire force-pushed the feature/ins-2119-inso-cli-linting-output-logs branch from 5b734c0 to b81db16 Compare November 15, 2022 16:37
@filfreire filfreire enabled auto-merge (squash) November 15, 2022 16:37
@filfreire filfreire merged commit 4fa2e4e into develop Nov 15, 2022
@filfreire filfreire deleted the feature/ins-2119-inso-cli-linting-output-logs branch November 15, 2022 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants