fix response pane flash #5453
Merged
fix response pane flash #5453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filfreire
approved these changes
Nov 23, 2022
pavkout
pushed a commit
to pavkout/insomnia
that referenced
this pull request
Jan 18, 2023
* fix typed get body functions * remove console log * fix response flash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog(Fixes): Fixed an issue that caused the response pane to sometimes flash for a brief moment
removes some indirection caused by generics and function chaining, ensured error cases and typed and handled by callers.
I chose to infer stream type using typeof body === 'string'
open to suggestions to a better approach, or removal of the optional error argument.
also simplify response viewer
closes INS-2165