Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom spectral ruleset in inso #5488

Merged
merged 9 commits into from
Dec 14, 2022

Conversation

jackkav
Copy link
Contributor

@jackkav jackkav commented Dec 6, 2022

changelog(Inso CLI): Added support custom Ruleset files for Inso CLI. To use it run inso lint spec ./oas.yaml with a .spectral.(yaml|yml|json|js) file in the same folder

Motivation: support custom spectral ruleset files

UX: inso lint spec ./oas.yaml (with .spectral.(yaml|yml|json|js) file in the same folder)

todo

  • added implicit custom ruleset detection
  • accept yaml and json file types

future work

  • pass custom ruleset explicitly as an inso argument
  • add custom ruleset support in ui
    • (maybe)load spectral yaml from remote url explicitly
    • (maybe)implicitly detect .spectral.(yaml|yml|json|js) (in folder above .insomnia?) INS-2194

Related: #4149

Closes: INS-2184

@jackkav jackkav self-assigned this Dec 6, 2022
@jackkav jackkav requested a review from mheap December 6, 2022 14:54
@jackkav jackkav changed the title Spike/inso-custom-ruleset Support inso custom ruleset Dec 6, 2022
@jackkav jackkav changed the title Support inso custom ruleset Support custom ruleset in inso Dec 6, 2022
@jackkav jackkav force-pushed the spike/inso-custom-ruleset branch from 9b57431 to 9d3fd1c Compare December 7, 2022 14:58
@jackkav jackkav marked this pull request as ready for review December 7, 2022 16:36
@jackkav jackkav requested a review from a team December 7, 2022 16:36
@jackkav jackkav changed the title Support custom ruleset in inso Support custom spectral ruleset in inso Dec 7, 2022
@marckong marckong requested a review from a team December 7, 2022 16:49
@filfreire filfreire force-pushed the spike/inso-custom-ruleset branch from 97d0b8c to 0ebd60d Compare December 14, 2022 10:59
@jackkav jackkav merged commit ed34090 into Kong:develop Dec 14, 2022
@jackkav jackkav deleted the spike/inso-custom-ruleset branch December 14, 2022 11:47
pavkout pushed a commit to pavkout/insomnia that referenced this pull request Jan 18, 2023
* first pass

* package lock

* provided ruleset is not an object

* works

* support multiple extensions

* fix test

* lower coverage threshold

* remove unused test

* remove only
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants