-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ca cert support #5498
ca cert support #5498
Conversation
I think it would be most beneficial to take in the CA exactly as given and leave it up to the user to merge as needed. |
No strong preference on this. Agree with Erik to leave it to the user to merge. Maybe good to also have a checkbox option to enable/disable the default/system CAs, to prevent the server certificate to be verified by those by accident...? |
4a872ed
to
5b0566d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, didn't test, hoping for the best
* exploration of new data model * POC second pass * fix * fix types * improve layout
Sorry for necroing this - but is it possible to import a custom RootCA globally instead? |
changelog(Improvements): Added support for setting CA certificates in workspace settings
questions
Related discussion: #3617
Related issue: #675
Related PR: #3203
Closes: INS-320
Closes: INS-322
Closes: INS-1669