gRPC server reflection support #5518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackkav
force-pushed
the
refactor/grpc-towards-reflection
branch
from
b286c50 to
cbb1837
Compare
zekth
reviewed
Dec 14, 2022
| @@ -211,5 +212,8 @@ | |||
| }, | |||
| "dev": { | |||
| "dev-server-port": 3334 | |||
| }, | |||
| "overrides": { | |||
| "protobufjs": "7.1.2" | |||
There was a problem hiding this comment.
Might be worth writing a comment about the issue without the override with the libs import 6.9.x
There was a problem hiding this comment.
I am planning to remove the overrides, I've attempted to bump protobuf.js in a fork of grpc-reflection-js but no luck yet. I'll add it to the todo, may come in a follow up PR.
filfreire
approved these changes
Dec 14, 2022
| const packageDefinition = protoLoader.loadFileDescriptorSetFromObject(descriptorMessage, {}); | ||
| return getMethodsFromPackageDefinition(packageDefinition); | ||
| } catch (e) { | ||
| console.error(e); |
There was a problem hiding this comment.
Maybe we could surface errors to the UI. For example - if the user is not able to connect to the server, we can see an error on console, but the UI silently fails.
jackkav
force-pushed
the
refactor/grpc-towards-reflection
branch
from
784b1c4 to
690cd2a
Compare
jackkav
force-pushed
the
refactor/grpc-towards-reflection
branch
from
690cd2a to
0aeceba
Compare
pavkout
pushed a commit
to pavkout/insomnia
that referenced
this pull request
Jan 18, 2023
* eliminate grpc paths * add fake reflection ux * add grpc packages * basic ux * first working pass * package lock * reset selected protofile * fix types * ssl * improve naming * remove deprecated grpc url parse * remove broken test * replace grpc proto PR test with reflection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog(Improvements): Added gRPC Server Reflection support
Highlights:
Future work: