Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add routes for git operations #5523

Merged
merged 13 commits into from
Dec 15, 2022
Merged

Conversation

gatzjames
Copy link
Contributor

@gatzjames gatzjames commented Dec 14, 2022

changelog(Improvements): Added some minor improvements for Git operations

Highlights:

  • Updates git operations to use the routing paradigm

@gatzjames gatzjames requested a review from a team December 14, 2022 15:18
@gatzjames gatzjames self-assigned this Dec 14, 2022
@gatzjames gatzjames force-pushed the feat/git-sync-routes branch 3 times, most recently from 64965a2 to baa4192 Compare December 15, 2022 08:27
@gatzjames gatzjames marked this pull request as ready for review December 15, 2022 08:46
@gatzjames gatzjames force-pushed the feat/git-sync-routes branch from baa4192 to 5ea6cab Compare December 15, 2022 08:46
Comment on lines +285 to +287
path: 'repo',
loader: async (...args) => (await import('./routes/git-actions')).gitRepoLoader(...args),
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be nice to put loaders first in lists of actions, but not a blocker

@jackkav jackkav force-pushed the feat/git-sync-routes branch from c932fe3 to 7d0d2e0 Compare December 15, 2022 14:53
@jackkav jackkav enabled auto-merge (squash) December 15, 2022 14:53
@jackkav jackkav merged commit f7beb00 into Kong:develop Dec 15, 2022
pavkout pushed a commit to pavkout/insomnia that referenced this pull request Jan 18, 2023
* Add repo-clone-modal

* remove unused var

* remove disabled uri input

* clone/setup git repository

* git branches

* log modal and branches modal

* git staging modal

* delete unused file

* remove unused test

* fix test lint

* fix e2e test

* display the correct file type in the staging modal

* fix check all checkboxes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants