Feature/ins-2070-bug-updowntabshifttab-not-working #5615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatzjames
force-pushed
the
feature/ins-2070-bug-updowntabshifttab-not-working
branch
from
c099a4d to
e703e7f
Compare
pavkout
commented
Jan 17, 2023
| const ref = useRef<HTMLLIElement>(null); | ||
|
|
||
| // @ts-expect-error -- TSCONVERSION | ||
| const withPrompt = item.rendered?.props?.withPrompt || undefined; |
pavkout
force-pushed
the
feature/ins-2070-bug-updowntabshifttab-not-working
branch
2 times, most recently
from
6baaca2 to
45ad2fd
Compare
jackkav
reviewed
Jan 18, 2023
| @@ -7,82 +7,82 @@ test.describe('Debug-Sidebar', async () => { | |||
| test.slow(process.platform === 'darwin' || process.platform === 'win32', 'Slow app start on these platforms'); | |||
| test.beforeEach(async ({ app, page }) => { | |||
| await page.click('[data-testid="project"] >> text=Insomnia'); | |||
| await page.click('text=Create'); | |||
| await page.getByRole('button', { name: 'Create' }).click(); | |||
filfreire
approved these changes
Jan 19, 2023
pavkout
force-pushed
the
feature/ins-2070-bug-updowntabshifttab-not-working
branch
from
e66d8d2 to
c26a15c
Compare
pavkout
force-pushed
the
feature/ins-2070-bug-updowntabshifttab-not-working
branch
from
ea61cac to
0edad8f
Compare
jackkav
approved these changes
Jan 20, 2023
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog(Improvements): Overall improvements to dropdowns for better maintainability, keyboard navigation, and accessibility (Note: Search was removed from some dropdowns. If this was critical for you, create a feature request on our Github Issues specifying your use-case).
Redesign and refactor existing dropdown component
Highlights
Supported features
Currently supported behavior
In case the dropdown item is a prompt button the user have to press the button a second time to confirm
In case of any async call when user press a dropdown item
In case we have inputs like this ***
*** In this cases there is another one react aria component (useGridList) that we can use and in this way to simplify the logic and separate these two logics
Improvements
Currently we used dropdown-button component which is a wrapper of themed-button component with some extra style, in the future we can replace this dropdown-button with the themed-button and move the styles there.
Currently we have tree kind of selected styles, it will be good to choose one of these types and to have the same selected style for the whole app.
Currently we have two sort dropdown, it will be better to follow the same style (see photos)