remove bad CSS child combinator in markdown lists preview (#5526) #5630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filfreire
approved these changes
Jan 16, 2023
|
Thanks @leflores-fisi, this will go out in our next release 👍 |
|
@leflores-fisi you can claim a free tshirt for this PR contribution - find more at https://konghq.com/community/open-source-contribution |
Wow I definitely will, looks amazing!, thank you @filfreire!, also to the Insomnia team for such an amazing tool |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog(Fixes): Fixed an issue with how lists are displayed in markdown previews
Closes #5526
As described in my comment, the child combinator
>only match the direct descendants, so in nested lists the rule will not apply.The solution was to remove these child combinators, as there is no point in styling only the direct descendants of the markdown preview container. That's why this bug also appear in these situations:
Also fixed.