Skip to content

GQL third pass #5641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 10, 2023
Merged

GQL third pass #5641

merged 7 commits into from
Jan 10, 2023

Conversation

jackkav
Copy link
Contributor

@jackkav jackkav commented Jan 10, 2023

changelog(Fixes): Fixed an issue where renaming a GraphQL operation would not preserve the selected one

  • disable prettify action for variables
  • fallback to {} instead of null
  • fallback to first operation if none selected
  • preserve operation selection if name changes

@jackkav jackkav marked this pull request as ready for review January 10, 2023 08:34
@jackkav jackkav requested a review from a team January 10, 2023 08:34
@jackkav jackkav merged commit 18771f7 into Kong:develop Jan 10, 2023
@jackkav jackkav deleted the fix/gql-prettify-3rd-attempt branch January 10, 2023 14:41
kreosus pushed a commit to kreosus/insomnia that referenced this pull request Jan 10, 2023
* fallback to {} and only auto prettify

* tolerate operation name change

* fallback to first element on change

* handle empty query

* update operation names on empty query

* update the ast when we update the query

* remove log

Co-authored-by: gatzjames <jamesgatzos@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants