Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Atlassian ASAP Authentication Support #566
This PR adds a new authentication dropdown "Atlassian ASAP" that takes 5 fields: issuer, subject, audience, key id and private key. Input from those fields will be passed to jwt-authenticator which gives a JWT token to be embedded on the request as the
As part of the work a new npm dependency to jwt-authenticator is added.
See also ASAP spec here: https://s2sauth.bitbucket.io.
Note about private key field
The example shown in the placeholder is multi-line PEM format which doesn't work very well with nunjucks environment data (each newline has to be replaced with escaped '\n'), but jwt-authentication also support single line data-uri format (see
A possible future improvement is to ask the user whether they want to copy-paste the private key, or point directly to the file (maybe provide a select dropdown in the place of the private key label).
@gschier now I understand what you mean with the file template tag, thanks! Yes it would solve the problem. I'll raise another PR to reword the help tooltip to "Press CTRL+Space to use File Template Tag to read the private key directly from a file". What do you think?