Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix INS-2232 default theme darker #5666

Merged
merged 1 commit into from
Jan 13, 2023
Merged

Fix INS-2232 default theme darker #5666

merged 1 commit into from
Jan 13, 2023

Conversation

filfreire
Copy link
Member

@filfreire filfreire commented Jan 13, 2023 •
edited
Loading

changelog(Improvements): Edited the default theme so previously bright modals are now darker. The previous default theme is still available as the Legacy theme

Closes INS-2232

  • Makes default theme darker, while preserving default to not break theming after people upgrade
  • Created legacy theme in case folks want to go back to previous one

Before:
Screenshot 2023-01-13 at 12 47 09

After:

Screenshot 2023-01-13 at 12 51 05

Pros:

  • removes CS 1.6 flashbang effect when opening a modal like cookie editor or preferences. Also sparks joy

@filfreire filfreire requested a review from a team January 13, 2023 12:46
gatzjames
gatzjames approved these changes Jan 13, 2023
View reviewed changes
Copy link
Contributor

@gatzjames gatzjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

jackkav
jackkav approved these changes Jan 13, 2023
View reviewed changes
Copy link
Contributor

@jackkav jackkav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💄 📸

@jackkav jackkav enabled auto-merge (squash) January 13, 2023 12:54
@jackkav jackkav merged commit bdbc884 into Kong:develop Jan 13, 2023
@filfreire filfreire deleted the fix/INS-2232-default-theme-dark branch January 25, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackkav jackkav jackkav approved these changes

@gatzjames gatzjames gatzjames approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@filfreire @jackkav @gatzjames