Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oauth2: optional redirect uri fix #5703

Merged
merged 2 commits into from
Jan 19, 2023

Conversation

jackkav
Copy link
Contributor

@jackkav jackkav commented Jan 19, 2023

changelog(Improvements): OAuth2 is now looser, not requiring the server to respond with redirect url / allowing to unset it

uses a looser auth code regex in order to allow unset redirect_uri

Copy link
Contributor

@gatzjames gatzjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😁

@filfreire filfreire force-pushed the fix/oauth2-optional-redirect-uri branch from a5c240b to dab1327 Compare January 19, 2023 13:31
filfreire
filfreire approved these changes Jan 19, 2023
@filfreire filfreire enabled auto-merge (squash) January 19, 2023 13:33
@filfreire filfreire merged commit 9bafd22 into Kong:develop Jan 19, 2023
@ltressens
Copy link
Contributor

This breaks the OTP mechanism of some OAuth servers, for example Keycloak is now unusable with Insomnia.
This should have been added with a on/off flag in the settings or in the OAuth 2 tab.

@subnetmarco
Copy link
Member

@jackkav How do we address the regression described above?

@filfreire
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants