Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix URLTag in request history #5709

Merged
merged 1 commit into from
Jan 20, 2023
Merged

Fix URLTag in request history #5709

merged 1 commit into from
Jan 20, 2023

Conversation

magdalipka
Copy link
Contributor

@magdalipka magdalipka commented Jan 19, 2023 •
edited by filfreire
Loading

changelog(Improvements): URLs are now displayed on request history for failed requests

Closes #5708
URLTag in request history was not displaying url for failed requests, the history dropdown was using response.url - changed to request.url.

filfreire
filfreire approved these changes Jan 20, 2023
View reviewed changes
Copy link
Member

@filfreire filfreire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @magdalenalipka

Before
Screenshot 2023-01-20 at 09 39 58

After
Screenshot 2023-01-20 at 09 39 40

@filfreire filfreire requested a review from a team January 20, 2023 09:41
gatzjames
gatzjames approved these changes Jan 20, 2023
View reviewed changes
Copy link
Contributor

@gatzjames gatzjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It also makes more sense to display the request url in the tag in case of redirects etc 🙏

@gatzjames gatzjames enabled auto-merge (squash) January 20, 2023 11:06
@gatzjames gatzjames merged commit 90e014a into Kong:develop Jan 20, 2023
@filfreire
Copy link
Member

@magdalenalipka you can claim a free tshirt for this PR contribution - find more at https://konghq.com/community/open-source-contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gatzjames gatzjames gatzjames approved these changes

@filfreire filfreire filfreire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Request history missing URL for failed requests
3 participants
@magdalipka @filfreire @gatzjames