Skip to content

increase sidebar hl contrast in solarized #5717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 25, 2023

Conversation

noah-pauls
Copy link
Contributor

@noah-pauls noah-pauls commented Jan 25, 2023

Changelog(Fixes): Fixed the Solarized/Solarized Dark themes by increasing contrast between items in the Debug sidebar.

Fixes the Solarized/Solarized Dark themes to increase contrast between items in the Debug sidebar window. Non-selected item text is changed to the base01 color in Solarized (see here).

Example below, where the selected request is inside "My Folder".

Old:
image

New:
image

Default for reference:
image

Closes #5594

@noah-pauls noah-pauls changed the title increase sidebar hl contrast in solarized (#5594) increase sidebar hl contrast in solarized Jan 25, 2023
@filfreire
Copy link
Contributor

Thank you @noahmpauls 👍

@filfreire filfreire requested a review from a team January 25, 2023 10:42
@filfreire filfreire force-pushed the fix/solarized-sidebar-contrast branch from ed55688 to 5bf2bae Compare January 25, 2023 15:59
@filfreire filfreire enabled auto-merge (squash) January 25, 2023 15:59
@filfreire filfreire merged commit 110d020 into Kong:develop Jan 25, 2023
@filfreire
Copy link
Contributor

@noahmpauls you can claim a free tshirt for this PR contribution - find more at https://konghq.com/community/open-source-contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Solarized dark theme highlighting is "broken"
2 participants