Fix INS-2275 db not defined creating team branch #5719
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackkav
approved these changes
Jan 25, 2023
filfreire
deleted the
feature/ins-2275-db-not-defined-error-when-creating-team
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog(Fixes): Fixed an issue that cause a
db not definederror to show up when creating a new branch on Insomnia Cloud syncCloses INS-2275
We were missing
dbimport on the team sync. This doesn't get caught in local development, only on the packaged app.I went ahead and added the missing import and also tried cleanup a bit to avoid using the ts-expect error on similar function calls for team sync and git sync by forcing the type. In some cases had to do the
as unknown as <something>trick. Open to improvement suggestions.