Skip to content

Update workspace grid in project view #5745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 2, 2023
Merged

Update workspace grid in project view #5745

merged 2 commits into from
Feb 2, 2023

Conversation

gatzjames
Copy link
Contributor

@gatzjames gatzjames commented Feb 1, 2023 •
edited by filfreire
Loading

changelog(Improvements): Improvements to the dashboard UI

Updates the workspace grid so that the filters follow the size of it.

Highlights:

  • Simplified the layout using grid and removed a bunch of divs
  • The first row is sized based on the columns generated for the cards
  • Fixed an issue on smaller screens where the pane was not scrollable.

Closes INS-2329

image

@gatzjames gatzjames requested review from pavkout and a team February 1, 2023 18:31
@gatzjames gatzjames self-assigned this Feb 1, 2023
filfreire
filfreire approved these changes Feb 1, 2023
View reviewed changes
Copy link
Contributor

@filfreire filfreire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty project state is brokey, other than that - LGTM

image

jackkav
jackkav approved these changes Feb 1, 2023
View reviewed changes
Copy link
Contributor

@jackkav jackkav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

88 lines changed very lucky!

@filfreire filfreire merged commit 4521d80 into Kong:develop Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackkav jackkav jackkav approved these changes

@filfreire filfreire filfreire approved these changes

@pavkout pavkout Awaiting requested review from pavkout

Assignees

@gatzjames gatzjames

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gatzjames @jackkav @filfreire