Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #5722 : if redirectUrl is unset, do not match on it, but still match on it if set #5763

Merged

Conversation

ltressens
Copy link
Contributor

@ltressens ltressens commented Feb 8, 2023

changelog(Fixes): Added a fix for an issue where a match regex was still being applied if redirectUrl was not set on OAuth2 (related to #5722)

Closes #5722

If redirectUrl is unset, do not match on it, but still match on it if set.
Also check that 'code' and 'error' are not part of parameters name, but the full name of the parameter in URI

@filfreire filfreire requested a review from a team February 8, 2023 17:02
… set. Also check that 'code' and 'error' are not part of parameters name, but the full name of the parameter in URI
@filfreire filfreire force-pushed the fix/broken-oauth2-optional-redirect-uri branch from 27e825d to 85c9e2c Compare February 10, 2023 11:19
@filfreire
Copy link
Member

@ltressens thank you for contributing this! I'm going to go ahead and merge it and release it in today's beta release.

@jackkav heads up - merging this in time for beta, we can give it another pass later on

@filfreire filfreire merged commit c60a278 into Kong:develop Feb 10, 2023
@filfreire
Copy link
Member

@ltressens you can claim a free tshirt for this PR contribution - find more at https://konghq.com/community/open-source-contribution

@ltressens ltressens deleted the fix/broken-oauth2-optional-redirect-uri branch February 11, 2023 14:52
@filfreire filfreire mentioned this pull request Feb 24, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OAuth2 Authorization Code workflow breaks in v2022.7.5
2 participants