[Importers] OpenAPI and Swagger use underscore-dot syntax for environment variables #5807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filfreire
force-pushed
the
fix-importers-not-using-underscore-syntax-environment-variables
branch
from
2a852b9 to
812a04c
Compare
|
@Asamsig can you help us remember what was the motive behind this PR? Sorry in advance for not remembering. |
…rs to use underscore-dot syntax, instead of custom variable access.
filfreire
force-pushed
the
fix-importers-not-using-underscore-syntax-environment-variables
branch
from
812a04c to
3286cc0
Compare
|
Hi @filfreire , it started from this Slack message: https://getinsomnia.slack.com/archives/C3BBF236C/p1674209107398529. It is mostly a cosmetic change. Currently imported variables from a swagger/openapi spec will look like this: Since it doesn't use the underscore-syntax, the option |
filfreire
approved these changes
Mar 31, 2023
|
@Asamsig you can claim a free tshirt for this PR contribution - find more at https://konghq.com/community/open-source-contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog(Fixes): Fixed an issue where environment variables generated by OpenApi and Swagger importers now use underscore-dot syntax, instead of custom variable access.
Change environment variables generated by OpenApi and Swagger importers to use underscore-dot syntax, instead of custom variable access.