Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INS-2434: basic Kong 3.x support on Inso CLI #5827

Merged

Conversation

filfreire
Copy link
Member

@filfreire filfreire commented Mar 8, 2023

changelog(Inso CLI): Added basic support for Kong 3.0 for inso generate config with new --kongVersion option.
changelog(Improvements): Added basic support for Kong 3.0 declarative config generation from OpenAPI specs.

Adds basic support for Kong 3.0 on Inso CLI:

  • Changes _format_version to 3.0 when --kongVersion is 3
  • Prepends ~ to routes' path regex

Usage:

inso generate config <...> --kongVersion <value>  # version of target Kong instance, options are [legacy, 3] (default: legacy)

Insomnia Docs update PR - Kong/insomnia-docs#136

How to test

(Local build)

  • Checkout branch, run npm run bootstrap, run npm run inso-package. You should get a binary of inso cli that you can use under packages/insomnia-inso/binaries/inso

Or download the inso artifact from the GH Test Action artifacts

Example of the new binary running:
image

How to test on Insomnia app

  • Checkout branch, run npm run bootstrap, run npm run dev

Or download the recurring build artifact and try it out:

Screenshot 2023-03-10 at 14 50 43

Screenshot 2023-03-10 at 14 50 48

cc @mheap @rspurgeon

@filfreire filfreire changed the title feature/ins 2434 basic support for kong 3x on inso cli INS-2434: Kong 3.x support on Inso CLI Mar 8, 2023
@filfreire filfreire requested review from mheap, rspurgeon and a team March 8, 2023 19:20
@filfreire filfreire marked this pull request as ready for review March 8, 2023 19:39
@filfreire filfreire changed the title INS-2434: Kong 3.x support on Inso CLI INS-2434: basic Kong 3.x support on Inso CLI Mar 8, 2023
@filfreire filfreire force-pushed the feature/ins-2434-basic-support-for-kong-3x-on-inso-cli branch from 199850f to e02745f Compare March 9, 2023 15:46
@rspurgeon
Copy link

LGTM Tested locally with a few OAS, both the inso generate config and Insomnia UI changes.

Copy link
Contributor

@jackkav jackkav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Defaulting to legacy seems the only contention worth discussing. Not a blocker for me though.

Reference https://github.com/Kong/go-apiops

@filfreire filfreire merged commit 97a4d10 into develop Mar 14, 2023
@filfreire filfreire deleted the feature/ins-2434-basic-support-for-kong-3x-on-inso-cli branch March 14, 2023 15:17
@y0zg
Copy link

y0zg commented May 14, 2023

Do you know when this is going to be released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants