Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render webviews in UTF-8 #5836

Merged
merged 1 commit into from
Mar 15, 2023
Merged

Render webviews in UTF-8 #5836

merged 1 commit into from
Mar 15, 2023

Conversation

dnicolson
Copy link
Contributor

@dnicolson dnicolson commented Mar 10, 2023

changelog(Fixes): Fixed an issue where response previews were not properly decoded and rendered in UTF-8

This pull request renders webviews in UTF-8 as they are decoded in https://github.com/Kong/insomnia/blob/4612ef7/packages/insomnia/src/ui/components/viewers/response-viewer.tsx#L155, the content type is no longer needed as JavaScript will store the strings internally as UTF-16.

Closes #5803.

Copy link
Contributor

@jackkav jackkav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thanks! 🎸

@filfreire filfreire enabled auto-merge (squash) March 15, 2023 09:31
@filfreire filfreire merged commit 55b5260 into Kong:develop Mar 15, 2023
@filfreire
Copy link
Member

@dnicolson you can claim a free tshirt for this PR contribution - find more at https://konghq.com/community/open-source-contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Webview does not use the character set in the Content-Type HTTP header
3 participants