Add better support for binary data on WebSocket connections #5897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filfreire
changed the title
filfreire
force-pushed
the
feature/ins-2574-handle-binary-data-in-websockets
branch
from
1cfc1db to
15e8ba8
Compare
gatzjames
approved these changes
Apr 21, 2023
jackkav
reviewed
Apr 24, 2023
| if ('data' in event && typeof event.data === 'object') { | ||
| return 'Binary data'; | ||
| } | ||
| return event.data.toString('utf-8'); |
There was a problem hiding this comment.
utf8 is the default toString of a buffer so we shouldn't need to specify this
jackkav
reviewed
Apr 24, 2023
| raw = Buffer.from(event.data.data).toString('utf-8'); | ||
| } | ||
| } catch (err) { | ||
| // Ignore |
There was a problem hiding this comment.
the stringify should go in the catch next to the intent, and its safe to do it no matter what type it is.
jackkav
reviewed
Apr 24, 2023
Comment on lines
50
to
51
| if ('data' in event && typeof event.data === 'object' && 'data' in event.data && Array.isArray(event.data.data)) { | ||
| raw = Buffer.from(event.data.data).toString('utf-8'); |
There was a problem hiding this comment.
event.data should be an arraybuffer rather than an object containsing a array named data if im not mistaken websockets/ws#1222
jackkav
approved these changes
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes INS-2574
Closes #5864
changelog(Improvements): Add better support for binary data on WebSocket connections