Skip to content

Fix #5923: keybind action for switch environments #5998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 11, 2023
Merged

Fix #5923: keybind action for switch environments #5998

merged 2 commits into from
Jul 11, 2023

Conversation

sebastianjonasson
Copy link
Contributor

@sebastianjonasson sebastianjonasson commented May 26, 2023 •
edited by filfreire
Loading

changelog(Fixes): Fixed an issue with the keybind action to switch between environments

Description

Fix keybind (Ctrl+Shift+E) action: open environments dropdown when keybind is used.

Closes issue: #5923

Type of change

Trivial change.

The keybind broke in patch: e38ece1ab7a45671778fef9326fe4c18c4554154. I used previous commit (90e014a0057322eddbc9f729a4a505d8063ceb8d) as reference to restore the behavior of the keybind.

How Has This Been Tested?

Manually tested using Insomnia UI on Ubuntu 22.04:

  1. Open insomnia
  2. Run keybind Ctrl + Shift + E

On develop branch:

  • Does nothing

On this branch:

  • Opens environments dropdown

@sebastianjonasson sebastianjonasson mentioned this pull request May 26, 2023
Closed
1 task
@sebastianjonasson sebastianjonasson changed the title Fix: keybind action for switch environments Fix #5923: keybind action for switch environments May 26, 2023
@sebastianjonasson sebastianjonasson force-pushed the fix/keybind-switch-environment-2 branch 3 times, most recently from 8933559 to 0346c6a Compare May 31, 2023 06:34
@sebastianjonasson
Copy link
Contributor Author

@filfreire @jackkav - anyone able to take a look at this?

@jackkav jackkav requested a review from pavkout June 1, 2023 10:18
jackkav
jackkav approved these changes Jun 1, 2023
View reviewed changes
Copy link
Contributor

@jackkav jackkav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to hear if there is an alternative way to do this that doesn't require useImperativeHandle since the dropdown component was rewritten recently @pavkout / @gatzjames ?

Thanks for the contribution!

@jackkav jackkav requested a review from gatzjames June 1, 2023 10:22
@sebastianjonasson
Copy link
Contributor Author

I'd like to hear if there is an alternative way to do this that doesn't require useImperativeHandle since the dropdown component was rewritten recently @pavkout / @gatzjames ?

Thanks for the contribution!

Thanks!

@sebastianjonasson
Copy link
Contributor Author

@jackkav @filfreire @gatzjames @pavkout - Could I please get some feedback on this PR?

@gatzjames gatzjames force-pushed the fix/keybind-switch-environment-2 branch from 53a24d7 to 3d8b0e9 Compare June 20, 2023 10:16
gatzjames
gatzjames approved these changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@gatzjames gatzjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to use onOpen/onClose instead of the imperative handle!
Thanks for the help!

@jackkav jackkav force-pushed the fix/keybind-switch-environment-2 branch from 3d8b0e9 to 3b7fb38 Compare July 11, 2023 14:58
@jackkav jackkav enabled auto-merge July 11, 2023 14:59
@jackkav jackkav added this pull request to the merge queue Jul 11, 2023
Merged via the queue into Kong:develop with commit 0113ba0 Jul 11, 2023
@briancsinger
Copy link

The environment switch UI used to allow filtering. Did that get functionality get removed?

@filfreire
Copy link
Contributor

@sebastianjonasson you can claim a free tshirt for this PR contribution - find more at https://konghq.com/community/open-source-contribution

pavkout
pavkout reviewed Sep 29, 2023
View reviewed changes
Copy link
Contributor

@pavkout pavkout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

jackkav pushed a commit to jackkav/insomnia that referenced this pull request Nov 24, 2023
@sebastianjonasson @gatzjames @jackkav
Fix Kong#5923: keybind action for switch environments (Kong#5998)
d1b562b 
* Fix: keybind action for switch environments

* replace imperative handle with onOpen/onClose

---------

Co-authored-by: gatzjames <jamesgatzos@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavkout pavkout pavkout left review comments

@briancsinger briancsinger briancsinger approved these changes

@jackkav jackkav jackkav approved these changes

@gatzjames gatzjames gatzjames approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sebastianjonasson @briancsinger @filfreire @pavkout @jackkav @gatzjames