Skip to content

add support for multiple workspaces in one import file #6044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Jun 27, 2023

Conversation

jackkav
Copy link
Contributor

@jackkav jackkav commented Jun 21, 2023

add support for multiple workspaces in one import file

highlights

  • removes project and workspace selection, in favour of context and duplication of workspaces
  • removes import api spec import as a copy and paste would suffice
  • when importing from a run button, its possible to include no project or workspace so we should fallback to the default project and create a new workspace using a title found in the import file.
  • fixes incorrect logic which was importing collections as design documents
  • you can now import a whole project backup into an existing project, duplicating any already existing resources.
  • moves code coverage behind a CI flag

todo

  • fix export file name
  • remove selects
  • update scan results for multiple workspaces
  • update project name in title and labels to indicate context
  • remove workspace name override
  • decide on iteration approach to actual import
image

closes INS-2660
changelog(Improvements): Added support for importing multiple workspaces from one file.

@jackkav jackkav changed the title Feat/import-many-workspaces-2 add support for multiple workspaces in one import file Jun 21, 2023
@jackkav jackkav mentioned this pull request Jun 21, 2023
4 tasks
@jackkav jackkav force-pushed the feat/import-many-workspaces-2 branch from f0b7d50 to 189e581 Compare June 26, 2023 07:55
@jackkav jackkav requested a review from filfreire June 26, 2023 08:02
@jackkav jackkav marked this pull request as ready for review June 26, 2023 08:37
@jackkav jackkav requested a review from a team June 26, 2023 08:38
@jackkav jackkav self-assigned this Jun 26, 2023
@jackkav jackkav force-pushed the feat/import-many-workspaces-2 branch from 28677dd to cd4876d Compare June 27, 2023 15:06
@jackkav jackkav enabled auto-merge June 27, 2023 15:28
@jackkav jackkav added this pull request to the merge queue Jun 27, 2023
Merged via the queue into Kong:develop with commit d110638 Jun 27, 2023
@jackkav jackkav deleted the feat/import-many-workspaces-2 branch June 27, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants