Skip to content

improve in-app update experience #6064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 3, 2023
Merged

Conversation

jackkav
Copy link
Contributor

@jackkav jackkav commented Jun 27, 2023

Highlights

  • moves all remaining non-database IPC methods to preload
  • simplifies auto update logic
  • removes unnecessary IPC calls
  • noticed there is OS notification after download and in app notification after restart

todo

  • fix update getting stuck on checking...
  • fix update not happening after restart
  • move delay to downloaded event

risks

  • macos notification may need a permission

future

  • add toast notification, instead of OS notification for when download finishes

closes INS-2766

changelog(Improvement): Simplified app update experience:

@jackkav jackkav marked this pull request as ready for review June 28, 2023 12:02
@jackkav jackkav requested a review from a team June 28, 2023 14:50
@jackkav jackkav enabled auto-merge June 28, 2023 14:56
@jackkav jackkav added this pull request to the merge queue Jul 3, 2023
Merged via the queue into Kong:develop with commit 4af5326 Jul 3, 2023
@jackkav jackkav deleted the fix/update-experience branch July 3, 2023 15:24
jackkav added a commit to jackkav/insomnia that referenced this pull request Nov 24, 2023
* show backup status

* use preload

* clean up update code

* remove notifcation indirection

* cleanup app start event

* more cleaning

* remove confusing state and double ipc channels

* add update detection ocnsole log

* add error ux and tidy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants