fix: inso dereferencing/flattening $refs #6080
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filfreire
approved these changes
Jul 3, 2023
jackkav
added a commit
to jackkav/insomnia
that referenced
this pull request
Nov 24, 2023
* wip * manually revert 4872 disabling request validator circular refs * clean up * clean up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Inso is often used with deck which doesn't support $ref linking, so we must first dereference it.
#4872 appears to have broken dereferencing, preventing inso output to be consumed by deck.
Also I have added a OAS validation before dereferencing in order to reduce the number of cases we must support with this tool.
Two options for dealing with circular references:
We have chosen option 2
TODO
closes INS-2800
changelog(Fix): Reverted inso circular refs for request validator change in order to better support ref usage in general: