Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always show request timer with one decimal precision #617

Merged
merged 1 commit into from Nov 22, 2017

Conversation

@k-nut
Copy link
Contributor

k-nut commented Nov 22, 2017

I was slightly bothered by the request timer jumping because it was reducing its precision when it reached .0. I therefore propose to always call toFixed(1) on it for a nicer look.

Before

bad

After

good

Copy link
Contributor

gschier left a comment

Beautiful! That's much better.

@gschier gschier merged commit 1173001 into Kong:develop Nov 22, 2017
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@k-nut

This comment has been minimized.

Copy link
Contributor Author

k-nut commented Nov 22, 2017

Thank you, this was super quick! 🚀

@k-nut k-nut deleted the k-nut:timer-same-precision branch Nov 22, 2017
@gschier

This comment has been minimized.

Copy link
Contributor

gschier commented Nov 22, 2017

No problem. Thank you! Your patch will appear in the next release, hopefully by the end of the week. Congrats on your first contribution 👍 😄

luizmariz pushed a commit to luizmariz/insomnia that referenced this pull request Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.