fix: render fail on workspace dropdown in req group settings #6350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
We should merge the sidebar rewrite and retest this |
filfreire
force-pushed
the
chore/fix-reqgroup-settings-workspace-dropdown
branch
from
04b0717 to
32eac0f
Compare
filfreire
force-pushed
the
chore/fix-reqgroup-settings-workspace-dropdown
branch
from
32eac0f to
2fe1d75
Compare
jackkav
approved these changes
Aug 24, 2023
jackkav
added a commit
to jackkav/insomnia
that referenced
this pull request
Nov 24, 2023
* fix: render fail on workspace dropdown in req group settings * match move/copy select implementation * fix move request navigate --------- Co-authored-by: jackkav <jackkav@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog(Fixes): Fixed an issue where the workspace dropdown in the request folder settings would sometimes return an render fail error when picking through different workspaces to move/copy to.
Steps to reproduce:
Copying the approach we do for the same dropdown in request settings was enough to fix the issue.