re add user-agent #6436
Merged
re add user-agent #6436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackkav
force-pushed
the
revert/useragent-change
branch
from
ffa0bc8 to
5790df6
Compare
jackkav
added a commit
to jackkav/insomnia
that referenced
this pull request
Nov 24, 2023
* re add user-agent * fix lint * fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog(Fixes): Added a fallback to always have user-agent to deal with unforeseen consequences of allowing user-agent removal.
user-agent was added to the ui for new requests but not old ones and default user-agent was suppressed.
This caused unintended consequences with existing requests, which had a user-agent but now dont.
this PR should fix that issue by falling back to always have user-agent.
If we want to remove user-agent when it is disabled in headers tab for a request we will need to look at request rendering as disabled headers are filtered out there before they make it to curlRequest.