Skip to content

Local vault or remote project option for migration #6689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 13, 2023
Merged

Local vault or remote project option for migration #6689

merged 2 commits into from
Oct 13, 2023

Conversation

gatzjames
Copy link
Contributor

@gatzjames gatzjames commented Oct 13, 2023 •
edited by filfreire
Loading

changelog(Improvements): Show an option for how the migration should happen.

  • Local vault (default)
  • Cloud projects

Highlights:

  • We keep using the existing migration logic to make sure all projects are moved under the organization locally.
  • After that we check the user preference (local/remote) and if remote try to move the local projects to remote. If anything fails (Api error,offline etc) projects are still under the org as local and users can turn them into remote from the project settings.

@gatzjames gatzjames requested a review from a team October 13, 2023 10:11
@gatzjames gatzjames self-assigned this Oct 13, 2023
filfreire
filfreire approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@filfreire filfreire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, LGTM

@gatzjames gatzjames enabled auto-merge (squash) October 13, 2023 10:22
@gatzjames gatzjames merged commit 5b07693 into Kong:develop Oct 13, 2023
@gatzjames gatzjames deleted the feat/migration-storage-option branch October 13, 2023 10:26
jackkav pushed a commit to jackkav/insomnia that referenced this pull request Nov 24, 2023
@gatzjames @jackkav
Local vault or remote project option for migration (Kong#6689)
1cee3cc 
* allow users to chose local or remote storage for migration

* fix styles in project settings modal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filfreire filfreire filfreire approved these changes

Assignees

@gatzjames gatzjames

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gatzjames @filfreire