Skip to content

fix: user should be able to quickly rename requests by clicking [INS-3250] #6710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 2, 2023
Merged

fix: user should be able to quickly rename requests by clicking [INS-3250] #6710

merged 6 commits into from
Nov 2, 2023

Conversation

ihexxa
Copy link
Contributor

@ihexxa ihexxa commented Oct 23, 2023 •
edited by filfreire
Loading

changelog(Improvements): Added a quicker way for users to quickly rename requests by clicking on them

Changes:

  • enable quick renaming request by clicking

@ihexxa ihexxa self-assigned this Oct 23, 2023
@ihexxa ihexxa marked this pull request as draft October 23, 2023 08:49
@ihexxa ihexxa changed the title fix: use should be able to double click request item and rename it [INS-3250] fix: use should be able to quickly rename requests [INS-3250] Oct 24, 2023
ihexxa
ihexxa commented Oct 24, 2023
View reviewed changes
@ihexxa ihexxa force-pushed the fix/rename-req branch 3 times, most recently from 27c8a0d to 3d76d69 Compare October 27, 2023 08:55
@ihexxa ihexxa marked this pull request as ready for review October 27, 2023 12:40
@ihexxa ihexxa changed the title fix: use should be able to quickly rename requests [INS-3250] fix: user should be able to quickly rename requests by clicking [INS-3250] Oct 27, 2023
@jackkav
Copy link
Contributor

jackkav commented Oct 30, 2023 •
edited
Loading

Since double click is not encouraged with react-aria.
This PR is about making two mechanics play nicely.

  • navigate
  • rename

There seem to be only two approaches

  1. clicking the text triggers a rename
  2. clicking an edit icon triggers the rename

Problems:
option 1 can interfere with navigation
option 2 can reduce the space available to show the name

This PR appears to be applying option 1. I would encourage some group testing to address the problem with option 1 before approving/merging this PR.
Thanks.

@jackkav jackkav merged commit 54050fe into develop Nov 2, 2023
@jackkav jackkav deleted the fix/rename-req branch November 2, 2023 14:14
@nickvruiz
Copy link

Please revert this, it is frustrating.

@guilhermeferrari
Copy link

Please revert this, it is frustrating.

+1. At least give us the option to disable 😭

@bonetou
Copy link

bonetou commented Nov 10, 2023

Please revert this, it is frustrating 2.

@AntoRin
Copy link

AntoRin commented Nov 13, 2023

There is no way to know you are already in an edit mode, either. I'd rather have clicks used for navigation between requests. A double-click can open up the rename dialog.

@alisonsm92
Copy link

I'm having a bad experience after this modification. I think the clicks should be used to navigate the list of requests.
A double click can be used to rename.

@r1cardosouza
Copy link

bad idea. please, revert this!!!!!

@thedomeffm
Copy link

I thought it is a bug. Its super annoying.

jackkav pushed a commit to jackkav/insomnia that referenced this pull request Nov 24, 2023
@ihexxa @jackkav
fix: user should be able to quickly rename requests by clicking [INS-…
ecc7f08 
…3250] (Kong#6710)

* fix: use should be able to double click request item and rename it [INS-3250]

* fix: enable double clicking renaming for pinned requests

* fix: use editable input for renaming request name

* fix: incorrect indent

* fix: lint error

* test: add a test for quick renaming
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gatzjames gatzjames Awaiting requested review from gatzjames

@jackkav jackkav Awaiting requested review from jackkav

@filfreire filfreire Awaiting requested review from filfreire

Assignees

@ihexxa ihexxa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@ihexxa @jackkav @nickvruiz @guilhermeferrari @bonetou @AntoRin @alisonsm92 @r1cardosouza @thedomeffm