Skip to content

fix: enable confirmation before deleting a test suite [INS-3286] #6737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 2, 2023
Merged

fix: enable confirmation before deleting a test suite [INS-3286] #6737

merged 2 commits into from
Nov 2, 2023

Conversation

ihexxa
Copy link
Contributor

@ihexxa ihexxa commented Oct 31, 2023 •
edited by filfreire
Loading

changelog(Improvements): Added confirmation dialog before deleting a test suite

Changes:

  • enable confirmation before deleting a test suite
  • add a test for the operation

@ihexxa ihexxa marked this pull request as draft October 31, 2023 05:56
@ihexxa ihexxa self-assigned this Nov 1, 2023
@ihexxa ihexxa marked this pull request as ready for review November 1, 2023 06:13
@ihexxa ihexxa merged commit 3eb6141 into develop Nov 2, 2023
@ihexxa ihexxa deleted the fix-confirm-del-test branch November 2, 2023 01:58
jackkav pushed a commit to jackkav/insomnia that referenced this pull request Nov 24, 2023
@ihexxa @jackkav
fix: enable confirmation before deleting a test suite [INS-3286] (Kon…
ecbad51 
…g#6737)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackkav jackkav jackkav approved these changes

@filfreire filfreire Awaiting requested review from filfreire

@gatzjames gatzjames Awaiting requested review from gatzjames

Assignees

@ihexxa ihexxa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ihexxa @jackkav