fix: prevent yarn directory traversal on plugin installation#6829
Merged
gatzjames merged 2 commits intoKong:developfrom Feb 7, 2025
Merged
fix: prevent yarn directory traversal on plugin installation#6829gatzjames merged 2 commits intoKong:developfrom
gatzjames merged 2 commits intoKong:developfrom
Conversation
|
|
Contributor
Author
|
@gatzjames any reason in particular this was closed? |
gatzjames
force-pushed
the
fix/yarn-directory-traversal
branch
from
35b0626 to
041913e
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| const tmpDir = path.join(electron.app.getPath('temp'), `${lookupName}-${Date.now()}`); | ||
| await mkdir(tmpDir, { recursive: true }); | ||
| // Write a dummy package.json so that yarn doesn't traverse up the directory tree | ||
| await writeFile(path.join(tmpDir, 'package.json'), JSON.stringify({ license: 'ISC', workspaces: [] }), 'utf-8'); |
Check warning
Code scanning / Semgrep OSS
Semgrep Finding: javascript.lang.security.audit.path-traversal.path-join-resolve-traversal.path-join-resolve-traversal
Contributor
|
Thanks for the PR! |
gatzjames
approved these changes
Feb 7, 2025
pavkout
pushed a commit
to pavkout/insomnia
that referenced
this pull request
Feb 17, 2025
* fix: prevent yarn directory traversal on plugin installation fixes Kong#4041 * fix: fix code formatting in `install-plugin.ts`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #4041 (and possibly others)
Yarn would previously traverse up the directory tree looking for a workspace
package.json.This PR prevents this behavior by writing a dummy
package.jsonso yarn stops looking.Solves errors that occur when a
package.jsonexists in a parent directory (such as the user home directory or the root directory). Even when those errors don't occur, this may speed up execution very slightly by making fewer disk calls.