inso fifth pass #7601
Merged
inso fifth pass #7601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| function cli(input) { | ||
| return new Promise(resolve => { | ||
| exec(input, |
Check failure
Code scanning / Semgrep OSS
Semgrep Finding: javascript.lang.security.detect-child-process.detect-child-process
| const rulesetFileName = filesInSpecFolder.find(file => file.startsWith('.spectral')); | ||
| if (rulesetFileName) { | ||
| logger.trace(`Loading ruleset from \`${rulesetFileName}\``); | ||
| return path.resolve(path.dirname(filePath), rulesetFileName); |
Check warning
Code scanning / Semgrep OSS
Semgrep Finding: javascript.lang.security.audit.path-traversal.path-join-resolve-traversal.path-join-resolve-traversal
| const rulesetFileName = filesInSpecFolder.find(file => file.startsWith('.spectral')); | ||
| if (rulesetFileName) { | ||
| logger.trace(`Loading ruleset from \`${rulesetFileName}\``); | ||
| return path.resolve(path.dirname(filePath), rulesetFileName); |
Check warning
Code scanning / Semgrep OSS
Semgrep Finding: javascript.lang.security.audit.path-traversal.path-join-resolve-traversal.path-join-resolve-traversal
filfreire
previously approved these changes
Jul 9, 2024
gatzjames
previously approved these changes
Jul 9, 2024
filfreire
approved these changes
Jul 9, 2024
CurryYangxx
pushed a commit
that referenced
this pull request
Jul 11, 2024
* extract lint and export logic * add test and update doc * some thoughts * add test each * notes * comments * add more cases * improve types, flatten send request * collection runner poc * verbose * flatten * add bail * stabilise pathing * add test * fix type check * improve testing experience * fix tests * tidy up package.json * tidy up package and test.yml * remove old smoke test --------- Co-authored-by: Filipe Freire <filipe.freire@konghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issues found in experiment
ref INS-4021