Skip to content

Conversation

@jackkav
Copy link
Contributor

@jackkav jackkav commented Jul 17, 2024

Eliminates the send-request abstractions and transpiler step build:sr, in favour of npm workspaces monorepo references.

  • use direct import rom insomnia package
  • cleanup references to send-request
  • remove unnecessary const export
  • fix type-check and lint

closes INS-4189

@sentry
Copy link

sentry bot commented Jul 17, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: packages/insomnia/src/common/render.ts

Function Unhandled Issue
getRenderContext [**SyntaxError: Invalid regular expression: /{{ ?{{_['pvi-api-key']}}[

Did you find this useful? React with a 👍 or 👎

@jackkav jackkav marked this pull request as ready for review July 17, 2024 10:12
@jackkav jackkav requested a review from a team July 17, 2024 10:15
@jackkav jackkav force-pushed the remove-send-request branch from 4df969a to 043ed19 Compare July 17, 2024 14:23
@jackkav jackkav marked this pull request as draft July 18, 2024 08:16
@jackkav jackkav marked this pull request as ready for review July 18, 2024 11:07
@jackkav jackkav force-pushed the remove-send-request branch from 113a45a to 3640457 Compare July 18, 2024 13:05
@jackkav jackkav force-pushed the remove-send-request branch from 3640457 to b85cf43 Compare July 18, 2024 13:06
@jackkav jackkav merged commit 44642a4 into Kong:develop Jul 18, 2024
@jackkav jackkav deleted the remove-send-request branch July 18, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants