Skip to content

Fix: Keep equal sign for empty query parameters[INS-4228]#7802

Merged
filfreire merged 3 commits intodevelopfrom
fix/equal-sign-for-empty-query-parameters
Aug 6, 2024
Merged

Fix: Keep equal sign for empty query parameters[INS-4228]#7802
filfreire merged 3 commits intodevelopfrom
fix/equal-sign-for-empty-query-parameters

Conversation

@cwangsmv
Copy link
Copy Markdown
Contributor

@cwangsmv cwangsmv commented Aug 5, 2024

Relates to #2111

Add a strictNullHandling option for smartEncodeUrl.
By default, query string with equal sign(&foo=) or without equal sign(&foo) will converted to empty string as search param value.
When this option is enabled, with equal sign(&foo=) will parsed as empty string in search param value while without equal sign(&foo) will parsed as null in search param value. After all, we can distinguish the different between two situations.

Also update the querystring unit test.

@cwangsmv cwangsmv requested a review from a team August 5, 2024 03:35
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Aug 5, 2024

CLA assistant check
All committers have signed the CLA.

@subnetmarco subnetmarco requested a review from jackkav August 5, 2024 14:45
Copy link
Copy Markdown
Contributor

@jackkav jackkav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very thorough work, great job @cwangsmv !

@filfreire filfreire force-pushed the fix/equal-sign-for-empty-query-parameters branch from add4f4e to c892e5f Compare August 5, 2024 15:36
@filfreire filfreire enabled auto-merge (squash) August 5, 2024 15:36
@filfreire filfreire merged commit 4d5cd4d into develop Aug 6, 2024
@filfreire filfreire deleted the fix/equal-sign-for-empty-query-parameters branch August 6, 2024 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants