Skip to content

Remove styled-components#7809

Merged
jackkav merged 66 commits intoKong:developfrom
jackkav:unstyled-components-1
Aug 7, 2024
Merged

Remove styled-components#7809
jackkav merged 66 commits intoKong:developfrom
jackkav:unstyled-components-1

Conversation

@jackkav
Copy link
Copy Markdown
Contributor

@jackkav jackkav commented Aug 5, 2024

motivation:

  • improve app start performance by delaying the load time needed to generate the css classes needed for styled
  • make more consistent the varieties of css (tailwind classes, inline styling, css files)
  • enable the package lock to be refreshed without breaking dropdown functionality full package lock refresh #7800

removes all styled components

  • get CI passing (Clone from github is failing)
  • remove package
  • fix old tab css (8)
  • fix old dropdown button css (21 😞 )
  • fix old themed button css (14)
  • convert some of the inline styles to tailwind classes

future work

  • git clone has extra scroll bars
  • plugins buttons are all jumbled
  • websocket event view height is messed up
  • cookie tab in response needs margin

@jackkav jackkav force-pushed the unstyled-components-1 branch from 7b07de5 to e99e0d1 Compare August 7, 2024 00:00
@jackkav jackkav marked this pull request as ready for review August 7, 2024 00:01
@jackkav jackkav changed the title Unstyled-components-1 Remove styled-components Aug 7, 2024
gatzjames
gatzjames previously approved these changes Aug 7, 2024
@gatzjames gatzjames force-pushed the unstyled-components-1 branch from 5797961 to 1fc29ec Compare August 7, 2024 10:27
@jackkav jackkav enabled auto-merge (squash) August 7, 2024 10:33
@jackkav jackkav disabled auto-merge August 7, 2024 12:08
@gatzjames gatzjames force-pushed the unstyled-components-1 branch from de3be42 to 8e5aefb Compare August 7, 2024 12:11
@jackkav jackkav merged commit 9f24405 into Kong:develop Aug 7, 2024
@jackkav jackkav deleted the unstyled-components-1 branch August 7, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants