Skip to content

Fix: GraphQL request export curl body issue and GraphQL payload delete issue[INS-4281]#7831

Merged
cwangsmv merged 5 commits into
developfrom
fix/graph-ql-variable-issue
Aug 14, 2024
Merged

Fix: GraphQL request export curl body issue and GraphQL payload delete issue[INS-4281]#7831
cwangsmv merged 5 commits into
developfrom
fix/graph-ql-variable-issue

Conversation

@cwangsmv
Copy link
Copy Markdown
Contributor

@cwangsmv cwangsmv commented Aug 13, 2024

Background

  1. When user exports GraphQL request as curl, the Query Variables value is exported as entire string rather than string from JSON.stringify. So user could not use the exported curl script.
  2. When user delete both Query & Query Variables in GraphQL editor and switch to JSON body, it will be confusing that the content is not cleared.
  • Add the GraphQL request body parse logic when export curl
  • Clear GraphQL request body when user delete both Query & Query Variables
  • Update smoke test for GraphQL request export

@cwangsmv cwangsmv requested review from ihexxa and marckong August 13, 2024 10:14
@cwangsmv cwangsmv marked this pull request as draft August 13, 2024 10:14
@cwangsmv cwangsmv marked this pull request as ready for review August 14, 2024 03:40
ihexxa
ihexxa previously approved these changes Aug 14, 2024
Copy link
Copy Markdown
Contributor

@ihexxa ihexxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, probably we could disable the failed ut temporarily in rebasing.

@cwangsmv cwangsmv force-pushed the fix/graph-ql-variable-issue branch from 09dc5fd to 3c659e8 Compare August 14, 2024 06:54
@cwangsmv cwangsmv merged commit 7776cb4 into develop Aug 14, 2024
@cwangsmv cwangsmv deleted the fix/graph-ql-variable-issue branch August 14, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants