chore: split packaging for windows builds [INS-3983]#7838
Merged
Conversation
filfreire
force-pushed
the
chore-split-packaging-for-windows-codesign
branch
from
1d6baba to
57103b2
Compare
marckong
approved these changes
Aug 22, 2024
filfreire
force-pushed
the
chore-split-packaging-for-windows-codesign
branch
from
3131f10 to
0587378
Compare
filfreire
force-pushed
the
chore-split-packaging-for-windows-codesign
branch
from
0587378 to
6a0644f
Compare
filfreire
force-pushed
the
chore-split-packaging-for-windows-codesign
branch
from
6a0644f to
922d096
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to INS-3983
Trying to split packaging into 2 stages so we can codesign both the executable as well as the installer.
This makes for now having to update to NSIS optional. We'd have the same issue moving from Squirrel to NSIS.
This is related also with #7837
Executable after installation now is code-signed: