fix: test-util snippet to proper status code check [no-ticket]#7844
Merged
filfreire merged 1 commit intoKong:developfrom Aug 20, 2024
Merged
fix: test-util snippet to proper status code check [no-ticket]#7844filfreire merged 1 commit intoKong:developfrom
filfreire merged 1 commit intoKong:developfrom
Conversation
gatzjames
approved these changes
Aug 16, 2024
ihexxa
approved these changes
Aug 19, 2024
Contributor
ihexxa
left a comment
ihexxa
left a comment
There was a problem hiding this comment.
LGTM, I also fixed this on the runner side.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
response.codereturns status code number. Before the snippet we were suggesting was wrong, checking the status code "string" instead.