fix: handle login when opening org logged out [INS-4330]#7865
Merged
filfreire merged 3 commits intoKong:developfrom Aug 23, 2024
Merged
Conversation
filfreire
force-pushed
the
feature/ins-4330-gracefullogin-on-org-open
branch
from
e249cd2 to
83890b7
Compare
gatzjames
approved these changes
Aug 23, 2024
filfreire
force-pushed
the
feature/ins-4330-gracefullogin-on-org-open
branch
from
e7283e6 to
31d6ea7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes INS-4330
When a user clicks "Open" on the website to open an organization in the electron app, but they are logged out on the electron app, we will now try to
Before, they would click on Open, but nothing would happen on the app if they were logged out.
Notes
To test locally, spin up the app, and then make sure you point to to
node_modules/electron/dist/Electron.appwhen trying to open the deep links:Otherwise the deep links will get caught by any production installation you might have of Insomnia