Skip to content

feat: after-response cli#7931

Merged
jackkav merged 10 commits into
Kong:developfrom
jackkav:feature/ins-4145-add-after-response-script-execution-to-cli
Sep 12, 2024
Merged

feat: after-response cli#7931
jackkav merged 10 commits into
Kong:developfrom
jackkav:feature/ins-4145-add-after-response-script-execution-to-cli

Conversation

@jackkav
Copy link
Copy Markdown
Contributor

@jackkav jackkav commented Sep 9, 2024

  • create example for testing
  • run example test
  • add TAP test formatting
  • after response script throws error, what do?
  • respect test reporter formatter config (scoped out)
  • feedback

future work

  • support multiple test output formats, spec, xml, html, etc...
  • perhaps use a test flag to indicate only test outputs are desirable

Comment thread packages/insomnia-sdk/src/objects/response.ts
@jackkav jackkav marked this pull request as ready for review September 10, 2024 10:43
@jackkav jackkav force-pushed the feature/ins-4145-add-after-response-script-execution-to-cli branch 2 times, most recently from 108d1a6 to cbcd774 Compare September 11, 2024 13:06
filfreire
filfreire previously approved these changes Sep 12, 2024
Copy link
Copy Markdown
Contributor

@filfreire filfreire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gatzjames gatzjames force-pushed the feature/ins-4145-add-after-response-script-execution-to-cli branch from f1006c1 to 5dfc031 Compare September 12, 2024 08:26
@jackkav jackkav force-pushed the feature/ins-4145-add-after-response-script-execution-to-cli branch from 5dfc031 to 73ceadc Compare September 12, 2024 09:30
@jackkav jackkav merged commit deccf97 into Kong:develop Sep 12, 2024
@jackkav jackkav deleted the feature/ins-4145-add-after-response-script-execution-to-cli branch September 12, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants