Skip to content

Conversation

@CurryYangxx
Copy link
Member

@CurryYangxx CurryYangxx commented Sep 10, 2024

Issue
When the nesting levels are deeper or there are too much children under workspace. The withDescendants will take a long time to find all requests.

Changes

  • Add a queryType param for withDescendants function to limit the types of database queries
  • pass stopType and queryType when call the withDescendants function in test-suit loader

@CurryYangxx CurryYangxx marked this pull request as draft September 10, 2024 03:24
@CurryYangxx CurryYangxx changed the title perf: test-suit loader improvement perf: test-suit loader improvement - [INS-4400] Sep 10, 2024
@CurryYangxx CurryYangxx requested a review from a team September 12, 2024 08:39
@CurryYangxx CurryYangxx marked this pull request as ready for review September 12, 2024 08:39
@jackkav
Copy link
Contributor

jackkav commented Sep 12, 2024

An alternative implementation would look like replacing stopType with queryType as they have overlapping behaviour.

Note: there are only 3 usages of stopType in the code and they all stop on request type, you could just set request as the query type and remove that argument completely.

image

@CurryYangxx
Copy link
Member Author

An alternative implementation would look like replacing stopType with queryType as they have overlapping behaviour.

Note: there are only 3 usages of stopType in the code and they all stop on request type, you could just set request as the query type and remove that argument completely.

@jackkav The request may not be a direct child of workspace, but a child of requestGroup. So we need to include both request and requestGroup in queryType, and let the query stop at reques type.

@CurryYangxx CurryYangxx merged commit 198388d into develop Sep 18, 2024
@CurryYangxx CurryYangxx deleted the perf/test-suit branch September 18, 2024 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants