fix: unpushed notification performance issue - #7966
Merged
Merged
Conversation
CurryYangxx
force-pushed
the
fix/unpushed-notification
branch
from
September 14, 2024 05:35
41c9478 to
cf692a2
Compare
CurryYangxx
marked this pull request as draft
September 16, 2024 04:06
CurryYangxx
force-pushed
the
fix/unpushed-notification
branch
from
September 18, 2024 03:39
4954fab to
f118f83
Compare
CurryYangxx
marked this pull request as ready for review
September 18, 2024 06:09
yaoweiprc
previously approved these changes
Sep 18, 2024
CurryYangxx
force-pushed
the
fix/unpushed-notification
branch
2 times, most recently
from
September 18, 2024 09:15
ff85690 to
b81d303
Compare
CurryYangxx
force-pushed
the
fix/unpushed-notification
branch
from
September 18, 2024 09:40
b81d303 to
b51f533
Compare
cwangsmv
self-requested a review
September 18, 2024 10:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #7946
Issue reason:
The
git/can-pushandgit/changesrun too often because of the react-router revalidation mechanism.Changes
shouldRevalidateoption to disable revalidationfetch.loadin useInterval hook, every 30sreact-router-domto fix theshouldRevalidatenot work (we updated in this pr bump: react-router #7795, but it seems to have been replaced because of the conflict)