Skip to content

runner refactoring pass #7975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jackkav merged 6 commits into from
Sep 19, 2024
Merged

runner refactoring pass #7975

jackkav merged 6 commits into from
Sep 19, 2024
+322 −133

Conversation

@jackkav
Copy link
Contributor

@jackkav jackkav commented Sep 19, 2024 •
edited
Loading

done

  • clarify iterations naming
  • replace useState with useLocalstorage, react-use is outdated, consider alternatives
  • userUploadEnv rename
  • move the orderedJSON out of common/send-request to cli.ts

future work

  • add test failure output
  • refine timeline serialize/deserialize

@jackkav jackkav changed the title rename iterations to iterationCount runner refactoring pass Sep 19, 2024
@jackkav jackkav marked this pull request as draft September 19, 2024 09:47
@jackkav jackkav marked this pull request as ready for review September 19, 2024 11:27
@jackkav jackkav requested a review from a team September 19, 2024 11:28
@jackkav jackkav force-pushed the refactor/test-runner-pass branch from d300cb9 to 9df370e Compare September 19, 2024 14:28
gatzjames
gatzjames approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@gatzjames gatzjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jackkav jackkav merged commit df2bc06 into Kong:develop Sep 19, 2024
@jackkav jackkav deleted the refactor/test-runner-pass branch September 19, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gatzjames gatzjames gatzjames approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jackkav @gatzjames