feat: missing variable improvement - [INS-4396] #7981
Conversation
CurryYangxx
changed the title
CurryYangxx
force-pushed
the
feat/env-missing
branch
from
64d56c0 to
f7c940d
Compare
|
On a related note, in order to feedback useful context to a CLI user, we may want to change how we handle these. Theres a ticket to address it here INS-4142, provided this PR doesn't make that any more difficult it should be fine. |
CurryYangxx
force-pushed
the
feat/env-missing
branch
from
f047d72 to
fe7ae39
Compare
@jackkav This PR just get all missing variable at once and change some UI, will not affect the original error handling. So I think this will not let it more difficult. |
CurryYangxx
force-pushed
the
feat/env-missing
branch
from
547ce2c to
33a0645
Compare
| // because nunjucks only report the first error, we need to extract all missing variables that are not present in the context | ||
| // for example, if the text is `{{ a }} {{ b }}`, nunjucks only report `a` is missing, but we need to report both `a` and `b` | ||
| export function extractVariableKey(text: string = '', templatingContext: Record<string, any>): string[] { | ||
| const regexVariable = /{{\s*([^ }]+)\s*}}/g; | ||
| const missingVariables: string[] = []; | ||
| let match; | ||
|
|
||
| while ((match = regexVariable.exec(text)) !== null) { | ||
| let variable = match[1]; | ||
| if (variable.includes('_.')) { | ||
| variable = variable.split('_.')[1]; | ||
| } | ||
| // Check if the variable is not present in the context | ||
| if (_.get(templatingContext, variable) === undefined) { | ||
| missingVariables.push(variable); | ||
| } | ||
| } | ||
| return missingVariables; |
There was a problem hiding this comment.
compare with template context and get all empty variables in one editor.
CurryYangxx
force-pushed
the
feat/env-missing
branch
2 times, most recently
from
a423967 to
11a6fe4
Compare
|
|
CurryYangxx
force-pushed
the
feat/env-missing
branch
from
11a6fe4 to
b784c04
Compare
4 participants
Changes
show all the missing environment variables in request
