feat(Proxy): use the system proxy option to always use the system proxy settings on insomnia requests#7982
Merged
gatzjames merged 1 commit intoSep 23, 2024
Conversation
gatzjames
force-pushed
the
feature/ins-4462-respect-os-proxy-settings
branch
from
September 20, 2024 12:07
5d6fb77 to
3eeef36
Compare
…n insomnia requests
gatzjames
force-pushed
the
feature/ins-4462-respect-os-proxy-settings
branch
from
September 23, 2024 12:23
3eeef36 to
f8cc957
Compare
gatzjames
marked this pull request as ready for review
September 23, 2024 12:23
filfreire
approved these changes
Sep 23, 2024
filfreire
left a comment
Contributor
There was a problem hiding this comment.
Tactical Approval, but actually tested, so it's a tactical blessing
CurryYangxx
reviewed
Sep 24, 2024
| proxyRules.push(`https=${parseProxyFromUrl(httpsProxy)}`); | ||
| } | ||
|
|
||
| session.defaultSession.resolveProxy; |
Member
There was a problem hiding this comment.
@gatzjames Is this line useful? resolveProxy is a function but we do not call it here.
Contributor
There was a problem hiding this comment.
Indeed this seems strange https://www.electronjs.org/docs/latest/api/session#sesresolveproxyurl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Highlights:
systemoption in the proxy mode in the electron session to use the system proxy settings when running network requestsCloses #7969
How to test:
squidon one computer (e.g.sudo apt install squid/etc/squid/squid.confconfig with this one:then restart squid
sudo systemctl restart squidnext on a Windows machine, go to Properties > Proxy settings and setup a proxy pointing to the machine you are running

squidon, example:and add 2 Outbound firewall rules to your windows machine (go to firewall, Advanced Firewall settings), one to block all traffic to port 80 and 443, and another to allow all traffic to
squidproxy port (in default case is3128