Persist runner request order #7984
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filfreire
previously approved these changes
Sep 23, 2024
Contributor
|
I propose to take care of at least following 2 problems before moving forward:
And the approach of persisting selection looks good. |
jackkav
force-pushed
the
persist-runner-sort-order
branch
from
75bbd79 to
80f318e
Compare
ihexxa
reviewed
Sep 23, 2024
| }); | ||
| const [allKeys, setAllKeys] = useLocalStorage<string[]>(localStorageKey + 'allKeys', { defaultValue: requestRows.map(item => item.id) }); | ||
| // request was added or removed | ||
| if (allKeys.length !== requestRows.length) { |
Contributor
There was a problem hiding this comment.
I think the condition is more complicated, e.g. this check might not work in this case: user adds one new request and deletes one while actually one request has changed.
| if (newRequest) { | ||
| setAllKeys([...allKeys, newRequest.id]); | ||
| } else { | ||
| setAllKeys(allKeys.filter(key => requestRows.map(r => r.id).includes(key))); |
Contributor
There was a problem hiding this comment.
The user could move one request to another place.
Contributor
Author
There was a problem hiding this comment.
thats true, feel free to create a new PR to address this.
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
future work
Ref: INS-4452
Ref #7980